Skip to content

fix: Add mollie-gateway-icon class to the icon html #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brtkwr merged 1 commit into from
Jul 9, 2025
Merged

fix: Add mollie-gateway-icon class to the icon html #310

brtkwr merged 1 commit into from
Jul 9, 2025

Conversation

@brtkwr
Copy link
Member

@brtkwr brtkwr commented Jul 9, 2025

No description provided.

@brtkwr brtkwr requested a review from a team July 9, 2025 17:20
@brtkwr brtkwr merged commit e0ac0b4 into main Jul 9, 2025
3 checks passed
@brtkwr brtkwr deleted the mollie-gateway-icon branch July 9, 2025 17:21
@github-actions
Copy link

github-actions bot commented Jul 9, 2025

🖌 Pre-commit success 🏆

Details 
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier:prettier@3.1.0.
[INFO] Initializing environment for https://github.com/two-inc/git-hooks.
[INFO] Installing environment for https://github.com/pre-commit/mirrors-prettier.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
prettier.............................................(no files to check)Skipped

Exit code: 0

Author ✍️@brtkwr

cursor[bot]
cursor bot reviewed Jul 9, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect CSS Class for Payment Gateway Icon

The get_icon() method in the WC_Twoinc class incorrectly uses the CSS class mollie-gateway-icon for the Two/Twoinc payment gateway icon. This class name is a remnant of copied code from a Mollie plugin and should be updated to a Two/Twoinc specific class (e.g., twoinc-gateway-icon).

class/WC_Twoinc.php#L2294-L2295

woocommerce-plugin/class/WC_Twoinc.php

Lines 2294 to 2295 in 1f7a62d

{
$icon_html = '<img src="' . esc_url($this->icon) . '" alt="' . esc_attr($this->title) . '" class="mollie-gateway-icon" />';

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cursor cursor[bot] cursor[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brtkwr